Re: [PATCH] bitops: Use volatile in generic atomic bitops.

From: Will Newton
Date: Wed Jul 27 2011 - 10:32:49 EST


On Wed, Jul 27, 2011 at 3:28 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Wednesday 27 July 2011, Will Newton wrote:
>> >
>> > Have you observed this behavior? The interrupt disable/enable should
>> > always come with a barrier that should prevent the bitops from
>> > leaking out, so I don't see how this causes problems in practice.
>>
>> Yes, although my arch does not have these barriers. Now I see from
>> memory-barriers.txt that lock/unlock are required to implement a
>> compiler barrier, sorry for the noise!
>
> Which architectures is this?

Imagination Technologies META, which is a custom in-house
architecture. No immediate plans to upstream unfortunately. :-/

FWIW I checked all the in-tree architectures and it seems everyone
else gets this right (although I got a bit lost with tile).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/