Re: [PATCH] vfs: avoid taking locks if inode not in lists

From: Christoph Hellwig
Date: Wed Jul 27 2011 - 17:01:16 EST


On Wed, Jul 27, 2011 at 10:59:57PM +0200, Andi Kleen wrote:
> > Btw, I wonder if you should micro-optimize things a bit further by
> > moving the unhashed checks from the deletion functions into the callers
> > and thus save a function call for each of them.
>
> If the caller is in the same file modern gcc is able to do that automatically
> if you're lucky enough ("partial inlining")
>
> I would not uglify the code for it.

Depending on how you look at it the code might actually be a tad
cleaner. One of called functions is outside of inode.c.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/