Re: broken checkpatch signature checking

From: Joe Perches
Date: Thu Jul 28 2011 - 00:41:52 EST


On Thu, 2011-07-28 at 00:33 -0400, Dave Jones wrote:
> The signature checking patches in commit 2011247550 have broken one use-case for me.
> I pipe the git-commits mailing list to it and skim the summary once a day[*]
> Because git indents its changelogs, every single commit is now warning
> with this..
> WARNING: Do not use whitespace before Signed-off-by:
> #5252:
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Dave
> [*] It's too noisy to do anything useful with right now, which is
> why I'd like to filter out all the whitespace crap, but hopefully
> that'll happen eventually.

Hey Dave.

Maybe you could use --ignore=BAD_SIGN_OFF for this reviewing?

I think that the general use case is OK.

I'm not sure that it's appropriate to use
checkpatch on git log output.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/