Re: [PATCHv2] DMAEngine: Let dmac drivers to set chan_id

[Jaswinder Singh]

On 28 July 2011 02:07, Russell King <rmk@xxxxxxxxxxxxxxxx> wrote:
> On Wed, Jul 27, 2011 at 08:00:23PM +0530, Jaswinder Singh wrote:
>> On 27 July 2011 14:32, Koul, Vinod <vinod.koul@xxxxxxxxx> wrote:
>> > You can have two different DMACs in same system. At least I have two
>> > from current intel_mid_dma which are used. Both give their channel id
>> > starting from 0, 1....
>> > Further as we integrate video, audio, spi, emmc dmacs possibility of
>> > having multiple dmacs will increase in a system
>>
>> Most of Samsung's S5P series have 3 DMACs - 2 for peripherals and 1 for
>> mem->mem But that is not the point.
>>
>> This patch in no way affects what values currently a dmac driver
>> assigns to chan_id
>
> Then *explain* how the chan_id is used to match the channel which the
> peripheral requires when you have three DMA controllers, each with
> channels numbered 0 to 7.
>
>> > Sorry I didn't get you.
>> > As I understand you are trying to simplify the filter function by
>> > assigning unique ids to all channels,
>>
>> No dear. Let me put it precisely.
>>
>> Even if we make no further change to the dmaengine, this patch is the right
>> thing to do today.
>
> You sound like a politician.  "the right thing to do" is a cop-out.  That
> says "believe me, I know I'm right, but I can't say why I'm right, I just
> am."  Basically, it means that the person saying it has no clue on the
> subject they're talking about.

Why don't you look at the _patch_ and see if it's correct or not ?
Rather than passing judgement on my character.

>
> If you do have a clue, then don't say that infuriating phrase, but give an
> actual reason.
>
Please look at the first few posts in this thread.
I and Dan have gone through it cleanly enough.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/