Re: per-cpu operation madness vs validation

From: Christoph Lameter
Date: Thu Jul 28 2011 - 09:51:24 EST


On Thu, 28 Jul 2011, Thomas Gleixner wrote:

> We just have to understand, that preempt_disable, bh_disable,
> irq_disable are cpu local BKLs with very subtle semantics which are
> pretty close to the original BKL horror. All these mechanisms are per
> cpu locks in fact and we need to get some annotation in place which
> will help understandability and debugability in the first place. The
> side effect that it will help RT to deal with that is - of course
> desired from our side - but not the primary goal of that excercise.

Well the use of the per cpu atomic operations instead of disabling
preemption or scheduling helps RT too by removing the need to do so from
critical OS paths. F.e. we were able to remove most of that from counter
increments. There is still some more work to be done with these
byte/packet counters there as well.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/