Re: [PATCH] sunrpc: use better NUMA affinities

From: J. Bruce Fields
Date: Fri Jul 29 2011 - 12:53:54 EST


On Fri, Jul 29, 2011 at 12:48:36PM -0400, bfields wrote:
> On Fri, Jul 29, 2011 at 11:30:05PM +1000, Greg Banks wrote:
> >
> >
> > Sent from my iPhone
> >
> > On 29/07/2011, at 22:11, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> >
> > > Le vendredi 29 juillet 2011 Ã 21:58 +1000, Greg Banks a Ãcrit :
> > >
> > >>
> > >> Sure, and a whole lot of the callsites are ("..._%d", cpu), hence the
> > >> unfortune :(
> > >
> > > BTW, we could name nfsd threads differently :
> > >
> > > Currently, they all are named : "nfsd"
> > >
> > > If SVC_POOL_PERCPU is selected, we could name them :
> > > nfsd_c0 -> nfsd_cN
> > >
> > > If SVC_POOL_PERNODE is selected, we could name them :
> > > nfsd_n0 -> nfsd_nN
> > >
> > > That would help to check with "ps aux" which cpu/nodes are under
> > > stress.
> > >
> > >
> >
> > I like it!
>
> Yup, patch welcomed.--b.

(Annoying fact: some initscripts stop nfsd using a rough equivalent of
"killall nfsd". So the name of the threads is arguably ABI. I think
those initscripts are nuts and deserve what they get, but that may be
because I'm forgetting the reason they do that.)

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/