Re: [PATCH 15/18] dmaengine/amba-pl08x: Pass flow controllerinformation with slave channel data

From: viresh kumar
Date: Sun Jul 31 2011 - 01:37:00 EST


On 7/30/11, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> 2011/7/29 Viresh Kumar <viresh.kumar@xxxxxx>:
>
> I have the same comment as Russell basically:
>
>> @@ -65,6 +69,7 @@ struct pl08x_channel_data {
>> int max_signal;
>> u32 muxval;
>> u32 cctl;
>> + u32 fc;
>
> bool device_fc;
>
> or similar. Then encode the necessary bits if the device controls
> flow, and fall back to default (DMAC control) otherwise.
>

Yes. I thought of exactly the same code.

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/