Re: kbuild: prevent make from deleting _shipped files

[Arnaud Lacombe]

Hi,

On Sun, Jul 31, 2011 at 12:21 PM, Arnaud Lacombe <lacombar@xxxxxxxxx> wrote:
> Hi,
>
> On Sun, Jul 31, 2011 at 11:37 AM, Peter Foley <pefoley2@xxxxxxxxxxx> wrote:
>> commit 7373f4f (kbuild: add implicit rules for parser generation)
>> created a implicit rule chain (%.c: %.c_shipped: %.y). This causes make to delete the _shipped files
>> because it considers them intermediate files. Mark the _shipped files PRECIOUS
>> to prevent make from deleting them.
>>
>> Signed-off-by: Peter Foley <pefoley2@xxxxxxxxxxx>
> What make are you using, and what command triggers the issue ?
>
> Those rules should only be visible on parser regeneration (ie.
> REGENERATE_PARSERS defined). make 3.82 does not seem to trigger the
> issue:
>
> % make -v
> GNU Make 3.82
>
> % make REGENERATE_PARSERS=y defconfig
>  HOSTCC  scripts/basic/fixdep
>  HOSTCC  scripts/kconfig/conf.o
>  SHIPPED scripts/kconfig/zconf.tab.c
>  SHIPPED scripts/kconfig/zconf.lex.c
>  SHIPPED scripts/kconfig/zconf.hash.c
>  HOSTCC  scripts/kconfig/zconf.tab.o
>  HOSTLD  scripts/kconfig/conf
> *** Default configuration is based on 'x86_64_defconfig'
> [...]
>
> The shipped file are still there:
>
> % ls scripts/kconfig/*_shipped
> scripts/kconfig/zconf.hash.c_shipped
> scripts/kconfig/zconf.lex.c_shipped
> scripts/kconfig/zconf.tab.c_shipped
>
a bare make-3.81 from ftp.gnu.org built on a Fedora 14 behave the same.

I definitively needs enlightenment on this one :)

Thanks,
 - Arnaud
>
>> ---
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index aeea84a..5d986d9 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -167,6 +167,7 @@ ifdef REGENERATE_PARSERS
>>  quiet_cmd_gperf = GPERF $@
>>       cmd_gperf = gperf -t --output-file $@ -a -C -E -g -k 1,3,$$ -p -t $<
>>
>> +.PRECIOUS: $(src)/%.hash.c_shipped
>>  $(src)/%.hash.c_shipped: $(src)/%.gperf
>>        $(call cmd,gperf)
>>
>> @@ -177,6 +178,7 @@ LEX_PREFIX = $(if $(LEX_PREFIX_${baseprereq}),$(LEX_PREFIX_${baseprereq}),yy)
>>  quiet_cmd_flex = LEX     $@
>>       cmd_flex = flex -o$@ -L -P $(LEX_PREFIX) $<
>>
>> +.PRECIOUS: $(src)/%.lex.c_shipped
>>  $(src)/%.lex.c_shipped: $(src)/%.l
>>        $(call cmd,flex)
>>
>> @@ -187,12 +189,14 @@ YACC_PREFIX = $(if $(YACC_PREFIX_${baseprereq}),$(YACC_PREFIX_${baseprereq}),yy)
>>  quiet_cmd_bison = YACC    $@
>>       cmd_bison = bison -o$@ -t -l -p $(YACC_PREFIX) $<
>>
>> +.PRECIOUS: $(src)/%.tab.c_shipped
>>  $(src)/%.tab.c_shipped: $(src)/%.y
>>        $(call cmd,bison)
>>
>>  quiet_cmd_bison_h = YACC    $@
>>       cmd_bison_h = bison -o/dev/null --defines=$@ -t -l -p $(YACC_PREFIX) $<
>>
>> +.PRECIOUS: $(src)/%.tab.h_shipped
>>  $(src)/%.tab.h_shipped: $(src)/%.y
>>        $(call cmd,bison_h)
>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/