Re: Please pull NFS client changes

From: Trond Myklebust
Date: Sun Jul 31 2011 - 15:59:03 EST


On Sun, 2011-07-31 at 21:46 +0200, Jens Axboe wrote:
> On 2011-07-31 21:39, Trond Myklebust wrote:
> > On Sun, 2011-07-31 at 21:14 +0200, Jens Axboe wrote:
> >> On 2011-07-31 20:24, Christoph Hellwig wrote:
> >>> How does this manage to include the pnfs block code, which only was posted
> >>> on the list a few hours before the pull request, and which doesn't
> >>> appear to past testing very well (although the major issue seems to be
> >>> core nfs code)?
> >>
> >> And it doesn't even compile:
> >>
> >> In file included from fs/nfs/client.c:51:0:
> >> fs/nfs/pnfs.h:384:1: error: expected identifier or â(â before â{â token
> >> fs/nfs/client.c: In function ânfs_server_set_fsinfoâ:
> >> fs/nfs/client.c:939:8: error: âstruct nfs_serverâ has no member named
> >> âpnfs_blksizeâ
> >> fs/nfs/client.c: At top level:
> >> fs/nfs/pnfs.h:382:20: warning: âset_pnfs_layoutdriverâ used but never
> >> defined [enabled by default]
> >> make[2]: *** [fs/nfs/client.o] Error 1
> >
> > Sigh. This should fix it...
>
> Only the first one, there are two independent places it broke. You
> missed this bit:
>
> fs/nfs/client.c:939:8: error: âstruct nfs_serverâ has no member named

How's this?

8<--------------------------------------------------------------------------------------