Re: [Regression] Commit 02c24a82187d5a628c68edfe71ae60dc135cd178breaks s2disk

From: Linus Torvalds
Date: Mon Aug 01 2011 - 21:22:31 EST


On Mon, Aug 1, 2011 at 2:17 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
>
> Well, I'm not sure if the patch below is the right fix, but it evidently makes
> s2disk work for me again.

Looks right to me.

The only issue is whether we should use "db_mapping->i_mapping" or
"file->f_mapping". I think they are the same for block devices.

Al?

Also, what about some of the other fsync things that apparently
weren't updated to write back page caches. ps3flash_fsync? Others?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/