Re: [PATCH] pti: add missing CONFIG_PCI dependency

[J Freyensee]

On 08/03/2011 12:20 AM, Geert Uytterhoeven wrote:
> On Tue, Aug 2, 2011 at 17:11, Randy Dunlap<rdunlap@xxxxxxxxxxxx>  wrote:
> > On Tue, 2 Aug 2011 10:08:34 +0200 Heiko Carstens wrote:
> >
> > > From: Heiko Carstens<heiko.carstens@xxxxxxxxxx>
> > >
> > > allmodconfig compile fails on s390 because of the new PTI driver:
> > >
> > > drivers/misc/pti.c:407:3: error: implicit declaration of function 'pci_iounmap'
> > > drivers/misc/pti.c:410:3: error: implicit declaration of function 'pci_release_region'
> > >
> > > Add a 'depends on PCI' statement so it doesn't get compiled.
> > >
> > > Cc: J Freyensee<james_p_freyensee@xxxxxxxxxxxxxxx>
> >
> > James has already acked my identical patch.
> > The problem seems to be that we don't have a drivers/misc/ maintainter to
> > merge the patch.
> >
> > Anyway:
> > Acked-by: Randy Dunlap<rdunlap@xxxxxxxxxxxx>
>
> It's also missing
>
> #include<linux/slab.h>
> #include<linux/uaccess.h>

Yes, the other patch and url I sent to Greg yesterday will take care of 
that.

Thanks


> Cfr. http://kisskb.ellerman.id.au/kisskb/buildresult/4429212/
>
> drivers/misc/pti.c:249: error: implicit declaration of function 'kmalloc'
> drivers/misc/pti.c:657: error: implicit declaration of function 'copy_from_user'
> drivers/misc/pti.c:848: error: implicit declaration of function 'kzalloc'
>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds


--
J (James/Jay) Freyensee
Storage Technology Group
Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/