Re: [PATCH 4/4] drivers/leds/leds-pca9532.c: delete uselessinitialization

From: Wolfram Sang
Date: Fri Aug 05 2011 - 18:37:57 EST


On Thu, Aug 04, 2011 at 12:29:34PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@xxxxxxx>
>
> Delete nontrivial initialization that is immediately overwritten by the
> result of an allocation function.
>
> The semantic match that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> type T;
> identifier i;
> expression e;
> @@
>
> (
> T i = \(0\|NULL\|ERR_PTR(...)\);
> |
> -T i = e;
> +T i;
> )
> ... when != i
> i = \(kzalloc\|kcalloc\|kmalloc\)(...);
>
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@xxxxxxx>

Acked-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>

BTW LED patches seem to go via akpm these days...

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

Attachment: signature.asc
Description: Digital signature