Re: [PATCH 5/5] writeback: IO-less balance_dirty_pages()

From: Wu Fengguang
Date: Sun Aug 07 2011 - 02:45:30 EST


> > + bw = (u64)base_bw * bw >> BANDWIDTH_CALC_SHIFT;
> > + pause = (HZ * pages_dirtied + bw / 2) / (bw | 1);
> > + pause = min(pause, MAX_PAUSE);
>
> Fix this build warning:
>
> mm/page-writeback.c: In function âbalance_dirty_pagesâ:
> mm/page-writeback.c:889:11: warning: comparison of distinct pointer types lacks a cast

Thanks! I'll fix it by changing `pause' to "long", since we'll have
negative pause time anyway when considering think time compensation.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/