Re: new sparse warning fs/cifs/cifsfs.c:168:15: warning: dereferenceof noderef expression fs/cifs/cifsfs.c:542:15: warning: dereference ofnoderef expression

[Steve French]

On Sun, Aug 7, 2011 at 12:48 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Sun, Aug 07, 2011 at 11:22:51AM -0500, Steve French wrote:
>> I noticed a series of sparse warnings (on all calls to cifs's GetXid
>> after building on a newly install fc15 system (yum installed a sparse
>> binary dated June 23).
>>
>> fs/cifs/cifsfs.c:168:15: warning: dereference of noderef expression
>> fs/cifs/cifsfs.c:542:15: warning: dereference of noderef expression
>>
>> Has sparse changed to add a new warning - I see (from quick search)
>> others getting this on other modules years ago, but I didn't see
>> anything obvious wrong with the definition of the function, and I
>> hadn't noticed sparse complaining about it before, and would like to
>> remove the 50+ new messages as they clutter the build output.
>
> It's not sparse change - the whinge comes from current_fsuid(), i.e. direct
> read of current->cred, even though it's declared with __rcu.  The thing is,
> current->cred does *not* need rcu_dereference() - only the task itself
> can change it.  Easily fixed...

your change makes sense - thx


Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/