Re: [PATCH] block: Make rq_affinity = 1 work as expected.

[Shaohua Li]

2011/8/5 Jens Axboe <jaxboe@xxxxxxxxxxxx>:
> On 2011-08-05 06:39, Tao Ma wrote:
>> From: Tao Ma <boyu.mt@xxxxxxxxxx>
>>
>> Commit 5757a6d76c introduced a new rq_affinity = 2 so as to make
>> the request completed in the __make_request cpu. But it makes the
>> old rq_affinity = 1 not work any more. The root cause is that
>> if the 'cpu' and 'req->cpu' is in the same group and cpu != req->cpu,
>> ccpu will be the same as group_cpu, so the completion will be
>> excuted in the 'cpu' not 'group_cpu'.
>>
>> This patch fix problem by simpling removing group_cpu and the codes
>> are more explicit now. If ccpu == cpu, we complete in cpu, otherwise
>> we raise_blk_irq to ccpu.
>
> Thanks Tao Ma, much more readable too.
Hi Jens,
I rethought the problem when I check interrupt in my system. I thought
we don't need Tao's patch though it makes the code behavior like before.
Let's take an example. My test box has cpu 0-7, one socket. Say request
is added in CPU 1, blk_complete_request occurs at CPU 7. Without Tao's
patch, softirq will be done at CPU 7. With it, an IPI will be directed to CPU 0,
and softirq will be done at CPU 0. In this case, doing softirq at CPU 0 and
CPU 7 have no difference and we can avoid an ipi if doing it in CPU 7.

we don't need to worry about blk_complete_request occurs at different CPUs.
it's called in interrupt handler. As far as I checked, all my HBA
cards (several LSI)
and AHCI don't support multiple MSI, so I assume blk_complete_request will
only be called in one CPU. Sure, if the assumption is wrong, we still need
Tao's patch, but in most common cases my assumption is correct.

Thanks,
Shaohua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/