Re: [PATCH 5/7] [media] ati_remote: add keymap for Medion X10 RFremote

[Jarod Wilson]

Anssi Hannula wrote:
> On 08.08.2011 08:57, Dmitry Torokhov wrote:
> > On Sun, Aug 07, 2011 at 01:18:11AM +0300, Anssi Hannula wrote:
> > > Add keymap for the Medion X10 RF remote which uses the ati_remote
> > > driver, and default to it based on the usb id.
> > Since rc-core supports loading custom keytmaps should we ass medion
> > keymap here?
> >
> > I think we should keep the original keymap to avoid regressions, but new
> > keymaps should be offloaded to udev.
>
> Well, I simply followed the convention, as all other remotes under
> media/ have the default table in-kernel.
>
> I'm not against putting it off-kernel, but in that case the same should
> be done for all new media devices. Is that the plan?

That's the long-term plan, but not every distro has a sufficiently new 
enough v4l-utils and ir-keytable with udev rules to load keymaps, so 
we've been adding default remotes in-kernel and userspace (effectively 
meaning duplicated keymap loads if the user does have ir-keytable with 
udev rules, but meh). I'd say add it for now, and when we get to the 
point of v4l-utils ubiquity, we can drop this along with all the other 
in-kernel rc keymaps.

--
Jarod Wilson
jarod@xxxxxxxxxx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/