Re: [Intel-gfx] [PATCH 2/4] drm/i915: Leave LVDS registers unlocked

From: Jesse Barnes
Date: Mon Aug 08 2011 - 12:30:26 EST


On Sat, 6 Aug 2011 10:54:06 -0700
Keith Packard <keithp@xxxxxxxxxx> wrote:

> There's no reason to relock them; it just makes operations more
> complex. This fixes DPMS where the panel registers were locked making
> the disable not work.
>
> Signed-off-by: Keith Packard <keithp@xxxxxxxxxx>

Yep, looks fine. The only think we might want to sprinkle about are
checks for panel off so we can avoid visible corruption if we whack
timing or fb stuff while the panel is on.

Reviewed-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>

--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/