Re: [Patch] Correct assignment of uid to gid in credentials

[Eric Dumazet]

Le lundi 08 aoÃt 2011 Ã 15:08 -0700, Tim Chen a Ãcrit :
> This patch corrects an erroneous assignment of uid to gid in credentials
> update.
> 
> Tim
> 
> Signed-off-by: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
> diff --git a/net/core/scm.c b/net/core/scm.c
> index 4c1ef02..811b53f 100644
> --- a/net/core/scm.c
> +++ b/net/core/scm.c
> @@ -192,7 +192,7 @@ int __scm_send(struct socket *sock, struct msghdr
> *msg, struct scm_cookie *p)
>  					goto error;
>  
>  				cred->uid = cred->euid = p->creds.uid;
> -				cred->gid = cred->egid = p->creds.uid;
> +				cred->gid = cred->egid = p->creds.gid;
>  				put_cred(p->cred);
>  				p->cred = cred;
>  			}
> 
> 

Good catch Tim.

BTW your patch is a bit flawed : one wrapped line and "---" marker
missing.

Could you add in Changelog bug came from commit 257b5358b32f17
(scm: Capture the full credentials of the scm sender) to ease stable
teams work ?
(linux-2.6.36 was the first kernel to include this commit)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/