Re: [PATCH ] printk: add module parameter console_suspend_enabled tocontrol console_suspend_enabled

[Dave Young]

On Tue, Aug 9, 2011 at 11:09 AM, Yanmin Zhang
<yanmin_zhang@xxxxxxxxxxxxxxx> wrote:
> We are enabling some power features on medfield. To test suspend-2-RAM
> conveniently, we need turn on/off console_suspend_enabled frequently.
>
> Below patch adds a module parameter, so users could change it by:
> /sys/module/printk/parameters/console_suspend_enabled

What about change name to no_console_suspend? Or it will be weird if
boot kernel with both no_console_suspend and
printk.console_suspend_enabled set.

>
> Signed-off-by: Yanmin Zhang <yanmin.zhang@xxxxxxxxx>
>
> ---
> Âkernel/printk.c | Â Â2 ++
> Â1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/printk.c b/kernel/printk.c
> index 37dff34..ce00f1b 100644
> --- a/kernel/printk.c
> +++ b/kernel/printk.c
> @@ -1106,6 +1106,8 @@ static int __init console_suspend_disable(char *str)
> Â Â Â Âreturn 1;
> Â}
> Â__setup("no_console_suspend", console_suspend_disable);
> +module_param_named(console_suspend_enabled, console_suspend_enabled,
> + Â Â Â Â Â Â Â bool, S_IRUGO | S_IWUSR);
>
> Â/**
> Â* suspend_console - suspend the console subsystem
> --
> 1.7.1
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>



-- 
Regards
Yang RuiRui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/