Re: [PATCH] arch:arm:plat-omap:iovmm: remove unused variable 'va'

From: Tony Lindgren
Date: Wed Aug 10 2011 - 07:18:11 EST


* Maxin B John <maxin.john@xxxxxxxxx> [110810 04:06]:
> ping.

Sorry I've been on vacation, applying to fixes.

Regards,

Tony


> On Mon, Aug 8, 2011 at 1:15 PM, Maxin B. John <maxin.john@xxxxxxxxx> wrote:
> > The pointer "va" returned from "phys_to_virt(pa)" is never used in
> > "sgtable_fill_kmalloc()".So,it is safe to remove this set-but-unused variable.
> >
> > Signed-off-by: Maxin B. John <maxin.john@xxxxxxxxx>
> > ---
> > diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
> > index c60737c..79e7fed 100644
> > --- a/arch/arm/plat-omap/iovmm.c
> > +++ b/arch/arm/plat-omap/iovmm.c
> > @@ -423,9 +423,6 @@ static void sgtable_fill_kmalloc(struct sg_table *sgt, u32 pa, u32 da,
> > Â{
> > Â Â Â Âunsigned int i;
> > Â Â Â Âstruct scatterlist *sg;
> > - Â Â Â void *va;
> > -
> > - Â Â Â va = phys_to_virt(pa);
> >
> > Â Â Â Âfor_each_sg(sgt->sgl, sg, sgt->nents, i) {
> > Â Â Â Â Â Â Â Âunsigned bytes;
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/