Re: [RFC][PATCH 2/2] spi: s3c64xx: Use clkdev for bus clock lookup

[Jassi Brar]

On Wed, Aug 10, 2011 at 5:33 PM, padma venkat <padma.kvr@xxxxxxxxx> wrote:
> Hi Jassi,
>
> On Tue, Aug 9, 2011 at 6:13 PM, Jassi Brar <jassisinghbrar@xxxxxxxxx> wrote:
>> On Tue, Aug 9, 2011 at 7:28 PM, Padmavathi Venna <padma.v@xxxxxxxxxxx> wrote:
>>> SPI driver is modified to lookup the bus clock using the
>>> alias name instead of getting clock name and clock
>>> number from platform data.
>> Cool.
>>
>>> Driver is modified to get the best source clock among the
>>> available source clocks for the required frequency.
>> I am not sure if this driver should be deciding which clock is 'best' for it.
>> Because ...
>> 1) Usually it's the board designer who decides which clock to run at
>> Âwhat speed based upon target device. So ideally, based upon use-case
>> the driver should simply get the 'best' clock from board via platform in a
>> format that is compliant to the 'generic clock api'.
> As per your comment I modified the code for board designer to supply the
> required list of source clocks. If this list is NULL then it Âuses the
> all available
> clock sources. I will resubmit this patch.
No dear. Not a list of clocks (that is property of the platform - not a board).
But get just one 'generic clock api' compliant clock from the board and use
it.
That will keep the driver simple for sure and IIUIC, in future anyways DT would
specify source clock for each peripheral. Grant ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/