Re: [RFC] catching sys_reboot syscall

From: Daniel Lezcano
Date: Wed Aug 10 2011 - 16:49:46 EST


On 08/10/2011 10:10 PM, Bruno Prémont wrote:
> Hi Daniel,
>
> [I'm adding containers ml as we had a discussion there some time ago
> for this feature]

[ ... ]

>> + if (cmd == LINUX_REBOOT_CMD_RESTART2)
>> + if (strncpy_from_user(&buffer[0], arg, sizeof(buffer) - 1) < 0)
>> + return -EFAULT;
>> +
>> + /* If we are not in the initial pid namespace, we send a signal
>> + * to the parent of this init pid namespace, notifying a shutdown
>> + * occured */
>> + if (pid_ns != &init_pid_ns)
>> + pid_namespace_reboot(pid_ns, cmd, buffer);
> Should there be a return here?
> Or does pid_namespace_reboot() never return by submitting signal to
> parent?

Yes, it does not return a value, like 'do_notify_parent_cldstop'

Thanks
-- Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/