Re: Missing put_cpu() in arch/ia64/sn/kernel/sn2/sn_hwperf.c?

[Jes Sorensen]

On 08/08/11 23:37, Tony Luck wrote:
> On Mon, Aug 8, 2011 at 11:05 AM, Thomas Meyer <thomas@xxxxxxxx> wrote:
>> The function sn_hwperf_op_cpu() seems to miss a corresponding put_cpu().
>>
>> Or is this done in another function? I didn't find it.
> 
> It would be hard to do it elsewhere - this function may not have done
> a get_cpu() [in the cpu == SN_HWPERF_ARG_ANY_CPU case].
> 
> The logic is a bit tortuous here ... perhaps simpler to split the tests
> up.  Does the attached patch look right?

Hi Tony,

You probably want someone from SGI to look at it, so I'll forward to
Robin Holt.

I haven't been at SGI for about 2 years now :)

Cheers,
Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/