RE: [PATCH] i2c/tegra: I2C driver uses thesuspend_noirq/resume_noirq

From: Stephen Warren
Date: Thu Aug 11 2011 - 15:36:23 EST


Mark Brown wrote at Saturday, August 06, 2011 2:48 AM:
> On Fri, Aug 05, 2011 at 09:33:31PM -0700, Colin Cross wrote:
...
> > NAK - moving the suspend order around is not the correct way to solve
> > this. If wm8903 needs to talk to the i2c bus in its suspend handler,
> > it needs to be child device on the i2c bus. suspend_noirq is for
>
> WM8903 is an I2C device. The problem is that it's suspended as part of
> the ASoC suspend since the audio subsystem is composed of multiple
> devices that all need to work together coherently. I did start doing
> some stuff to bodge around this like we do on probe but there are enough
> system wide problems with this that it didn't seem worth the complexity
> when the existing workarounds are so straightforward.

Colin, given Mark's explanation, are you OK with the patch now?

Thanks.

--
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/