Re: [PATCH] rtc: twl: Fix registration vs. init order

From: John Stultz
Date: Fri Aug 12 2011 - 19:37:20 EST


On Wed, 2011-08-10 at 20:20 -0700, Todd Poynor wrote:
> Only register as an RTC device after the hardware has been
> successfully initialized. The RTC class driver will call
> back to this driver to read a pending alarm, and other
> drivers watching for new devices on the RTC class may
> read the RTC time upon registration. Such access might
> occur while the RTC is stopped, prior to clearing
> pending alarms, etc.
>
> The new ordering also avoids leaving the platform
> device drvdata set to an unregistered struct rtc_device *
> on probe errors.
>
> Signed-off-by: Todd Poynor <toddpoynor@xxxxxxxxxx>

Thanks! Queued.
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/