Re: [PATCH 1/2] add SA_CLDREBOOT flag

From: Oleg Nesterov
Date: Sun Aug 14 2011 - 12:19:33 EST


On 08/11, Daniel Lezcano wrote:
>
> Add the SA_CLDREBOOT flag to enable the CLD_REBOOT on SIGCHLD
> when a process of a child pid namespace calls the reboot syscall.

I doubt this is really useful in general. SIGCHLD doesn't queue,
if the parent of init already has the pending SIGCHLD it won't see
CLD_REBOOTED anyway. Anyway, you do not need a special helper to
fill siginfo.

And personally I strongly dislike SA_CLDREBOOT. For what? Imho, this
is unnecessary complication. If we want SIGCHLD-on-reboot, just send
it unconditionally.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/