Re: [PATCH 19/41] OpenRISC: No need to reset handler if SA_ONESHOT

[Oleg Nesterov]

On 08/11, Matt Fleming wrote:
>
> get_signal_to_deliver() already resets the signal handler if
> SA_ONESHOT is set in ka->sa.sa_flags,

Yes.

> there's no need to do it again
> in handle_signal().

Again, this code in fact does nothing, it plays with the copy.

> Furthermore, because we were modifying
> ka->sa.sa_handler without holding ->sighand->siglock there's the
> potential we can race with another thread if it modifies the signal
> handlers.

and thus this is not true.



Afaics, the changelog should be fixed but the patch is fine ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/