Re: [PATCH] i2c: I2C_ELEKTOR should depend on HAS_IOPORT

[Jean Delvare]

On Tue, 16 Aug 2011 21:14:42 +0200, Geert Uytterhoeven wrote:
> Hi Jean,
> 
> On Tue, Aug 16, 2011 at 19:50, Jean Delvare <khali@xxxxxxxxxxxx> wrote:
> > On Mon, Â8 Aug 2011 13:20:46 +0200, Geert Uytterhoeven wrote:
> >> drivers/i2c/busses/i2c-elektor.c: In function âpcf_isa_initâ:
> >> drivers/i2c/busses/i2c-elektor.c:153: error: implicit declaration of function âioport_mapâ
> >> drivers/i2c/busses/i2c-elektor.c:153: warning: assignment makes pointer from integer without a cast
> >> drivers/i2c/busses/i2c-elektor.c: In function âelektor_probeâ:
> >> drivers/i2c/busses/i2c-elektor.c:287: error: implicit declaration of function âioport_unmapâ
> >>
> >> Since commit 82ed223c264def2b15ee4bec2e8c3048092ceb5f ("iomap: make IOPORT/PCI
> >> mapping functions conditional"), ioport_map() is only available on platforms
> >> that set HAS_IOPORT.
> >>
> >> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> >> ---
> >> Âdrivers/i2c/busses/Kconfig | Â Â2 +-
> >> Â1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> >> index 646068e..d1fc5cf 100644
> >> --- a/drivers/i2c/busses/Kconfig
> >> +++ b/drivers/i2c/busses/Kconfig
> >> @@ -789,7 +789,7 @@ config I2C_ACORN
> >>
> >> Âconfig I2C_ELEKTOR
> >> Â Â Â tristate "Elektor ISA card"
> >> - Â Â depends on ISA && BROKEN_ON_SMP
> >> + Â Â depends on ISA && HAS_IOPORT && BROKEN_ON_SMP
> >> Â Â Â select I2C_ALGOPCF
> >> Â Â Â help
> >> Â Â Â Â This supports the PCF8584 ISA bus I2C adapter. ÂSay Y if you own
> >
> > How can ISA be set if HAS_IOPORT is not? This shouldn't be allowed.
> 
> It's always been like that. With CONFIG_ISA, we have inb() and friends. But not
> ioport_map(), which was introduced more recently.

OK, fair enough. Patch applied, thanks.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/