[RFC PATCH 0/2] Sysfs group create for empty groups.

From: Jonathan Cameron
Date: Wed Aug 17 2011 - 06:09:36 EST


The following is a quick stab at avoiding a hideous work around
we are currently using in IIO. In some cases we have entire
attribute groups that are created from descriptions an array
of struct iio_chan_spec. To keep the reference counts sane
and cause subdirectories to be created we are currently using
dummy groups and dummy attribute arrays (provided once in the
core). This series is an initial probably stupid approach
to avoiding this.

Greg has expressed some doubts about whether subdirectories are
ever a good idea, but the problem occurs for the top level
directory as well (handled by patch 1).

Note, all attributes are created at probe time. Ultimately we
are just respinning the create_group code to allow us to create
the attributes from a device description rather than statically
allocating them in each driver (results in a massive reduction
in repeated code).

All opinions welcomed.

(this is definitely an rfc, the code isn't even tested yet)

Jonathan

p.s. Greg, sorry for pestering about this!

Jonathan Cameron (2):
sysfs: Allow for null group pointer in create_group
sysfs: Allow for groups with no attributes - grp->attrs = NULL.

fs/sysfs/group.c | 28 +++++++++++++++++-----------
1 files changed, 17 insertions(+), 11 deletions(-)

--
1.7.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/