Re: [PATCH] sparse: always enable endian checks

[AmÃrico Wang]

On Tue, Aug 16, 2011 at 2:33 AM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> On Mon, Aug 15, 2011 at 12:04:41PM -0400, Pavel Roskin wrote:
>> Checks enabled by __CHECK_ENDIAN__ produce less than a half of the
>> sparse warnings. ÂFor instance, the allyesconfig configuration on
>> linux-next (tag next-20110812) produces on x86_64:
>>
>> Â Â Â Â Â Â Â Â Âno __CHECK_ENDIAN__ Â with __CHECK_ENDIAN__
>> stderr bytes: Â Â1155037 Â Â Â Â Â Â Â 1992954 (73% increase)
>> stderr lines: Â Â10716 Â Â Â Â Â Â Â Â 18657 Â (74% increase)
>> affected files: Â1191 Â Â Â Â Â Â Â Â Â1458 Â Â(22% increase)
>>
>> It is no longer true that __CHECK_ENDIAN__ produces so many warnings
>> that other sparse warnings drown in the noise.
>>
>> Janitors going through the whole tree are already prepared to search for
>> the warnings they want to fix.
>>
>> The main point of this patch is to make sure that developers of a
>> particular driver who use sparse rarely get all the warnings for their
>> code even if they forget to specify __CHECK_ENDIAN__ or mistype it.
>>
>> Some developers actually added __CHECK_ENDIAN__ to the driver makefiles
>> so they don't forget to use it. ÂRemove them now.
>>
>> Remove all references to __CHECK_ENDIAN__ from the documentation except
>> the Chinese version, which would need to be updated separately.
>>
>> Signed-off-by: Pavel Roskin <proski@xxxxxxx>
> Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
>
> Maybe ask Michal to merge it?
>

ping Michal... :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/