Re: [PATCH 1/1] misc/pti.c: Fix build error when PCI is not selected

[Ingo Molnar]

* Greg KH <gregkh@xxxxxxx> wrote:

> On Thu, Aug 18, 2011 at 06:24:19PM +0200, Ingo Molnar wrote:
> > 
> > * Tracey Dent <tdent48227@xxxxxxxxx> wrote:
> > 
> > > On Thu, Aug 11, 2011 at 09:45:20AM -0700, Randy Dunlap wrote:
> > > > On Thu, 11 Aug 2011 12:23:06 -0400 Tracey Dent wrote:
> > > > 
> > > > > When you try to build INTEL_MID_PTI without having PCI
> > > > > enabled. It fails like this-
> > > > > 
> > > > >  CC [M]  drivers/misc/pti.o
> > > > >  drivers/misc/pti.c: In function âpti_pci_removeâ:
> > > > >  drivers/misc/pti.c:410: error: implicit declaration of function âpci_release_regionâ
> > > > >  drivers/misc/pti.c: In function âpti_pci_probeâ:
> > > > >  drivers/misc/pti.c:859: error: implicit declaration of function âpci_request_regionâ
> > > > > 
> > > > > So make INTEL_MID_PTI depend on PCI to fix build error.
> > > > 
> > > > I think (hope) that Greg already has a patch like this queued.
> > > > Greg- are you planning to push some patches soon?
> > > > 
> > > >
> > > 
> > > Okay, sorry for the noise then.
> > 
> > FYI, The fix is still not upstream, as of today's -git 
> > (72ed62bdc46d):
> > 
> > drivers/misc/pti.c:410:3: error: implicit declaration of function âpci_release_regionâ [-Werror=implicit-function-declaration]
> > drivers/misc/pti.c:859:2: error: implicit declaration of function âpci_request_regionâ [-Werror=implicit-function-declaration]
> 
> Yes, sorry, stuck at LinuxCon this week, will get it to Linus next 
> week. He's busy as well, so it's not like he could pull while 
> underwater anyway :)

No rush: the failures trigger pretty rately - just wanted to make 
sure it's not lost.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/