Re: + sysctl-add-proc_dointvec_unsigned-handler-update.patch added to-mm tree

[Dave Young]

On Fri, Aug 19, 2011 at 5:52 AM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 10 Jun 2011 17:51:50 +0800
> Dave Young <hidave.darkstar@xxxxxxxxx> wrote:
>
>> On Fri, Jun 10, 2011 at 1:19 AM, Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:
>> > On Wed, Jun 8, 2011 at 11:45 PM, Â<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>> >> --- a/kernel/sysctl.c~sysctl-add-proc_dointvec_unsigned-handler-update
>> >> +++ a/kernel/sysctl.c
>> >> @@ -2515,6 +2515,7 @@ int proc_dointvec_unsigned(struct ctl_ta
>> >> Â{
>> >> Â Â Â Âstruct do_proc_dointvec_minmax_conv_param param = {
>> >> Â Â Â Â Â Â Â Â.min = &zero,
>> >> + Â Â Â Â Â Â Â .max = (int *) table->extra2,
>> >> Â Â Â Â};
>> >> Â Â Â Âreturn do_proc_dointvec(table, write, buffer, lenp, ppos,
>> >> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âdo_proc_dointvec_minmax_conv, &param);
>> >
>> > This is still buggybecause "zero" is only 1 variable and max can be an array.
>> > Sysctl boundary comparisons are done element-by-element.
>>
>> Where's the array use case?
>
> Guys, these patches:
>
> sysctl-add-proc_dointvec_bool-handler.patch
> sysctl-use-proc_dointvec_bool-where-appropriate.patch
> sysctl-add-proc_dointvec_unsigned-handler.patch
> sysctl-add-proc_dointvec_unsigned-handler-update.patch
> sysctl-use-proc_dointvec_unsigned-where-appropriate.patch
>
> are still floating about in my tree, and stuck.
>
> As everyone has forgotten all about it I think I'll just drop the
> patches. ÂIf you're still motivated, please resend from scratch and
> let's take another look at them. ÂAnd this time please let's drive the
> discussion to a conclusion and not leave stuff floating around
> unresolved for months?
>

Sorry about that situation, Consider the alexey's concern maybe I will
 resend only the "bool" patches.

-- 
Regards
Yang RuiRui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/