Re: [RFC PATCH 00/32] Nohz cpusets (was: Nohz Tasks)

From: Paul Menage
Date: Sat Aug 20 2011 - 03:50:41 EST


On Thu, Aug 18, 2011 at 6:25 AM, Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
>>
>> Why not do it unconditionally?  That is, if all the conditions are
>> fulfilled, disable the tick regardless of any cpuset settings.
>
> Because I'm not sure it's a win on every workload. This involves
> some hooks here and there (syscall slow path), IPIs, etc...

I agree with Avi. I'd be inclined to investigate further to see if
there are any important workloads on which it's not a win - and then
add the extra complexity to control it from cpusets if necessary.
Unless there's really a good reason to make it configurable, it's
simpler to make it unconditional.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/