Re: [PATCH] staging: iio: industrialio-core: Fix compiler warning

From: Jonathan Cameron
Date: Mon Aug 22 2011 - 07:29:53 EST


On 08/22/11 11:08, Maxin B. John wrote:
> drivers/staging/iio/industrialio-core.c: In function
> 'iio_device_add_event_sysfs':
> drivers/staging/iio/industrialio-core.c:914: warning: 'mask' may be
> used uninitialized in this function
Thanks for the patch. It's actually a driver bug if this occurs.
We could have had a WARN_ON to let userspace know about the bug and
indeed taken the error route you suggest but
the relevant code has actually undergone a rewrite anyway so the
bit you are fixing doesn't exist any more anyway.

See http://git.kernel.org/?p=linux/kernel/git/jic23/iio-blue.git;a=summary
For our current dev tree (eats babies and includes all sorts of stuff
that hasn't been reviewed yet - so beware).

> Signed-off-by: Maxin B. John <maxin.john@xxxxxxxxx>
> ---
> diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
> index 19819e7..83b5953 100644
> --- a/drivers/staging/iio/industrialio-core.c
> +++ b/drivers/staging/iio/industrialio-core.c
> @@ -911,7 +911,7 @@ static int iio_device_add_event_sysfs(struct iio_dev *dev_info,
> struct iio_chan_spec const *chan)
> {
>
> - int ret = 0, i, mask;
> + int ret = 0, i, mask = 0;
> char *postfix;
> if (!chan->event_mask)
> return 0;
> @@ -944,6 +944,8 @@ static int iio_device_add_event_sysfs(struct iio_dev *dev_info,
> break;
> default:
> printk(KERN_INFO "currently unhandled type of event\n");
> + ret = -EINVAL;
> + goto error_ret;
> }
> ret = __iio_add_chan_devattr(postfix,
> NULL,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/