Re: [PATCH] coredump: fix pipe coredump when core limit is 0

[Jovi Zhang]

Sorry, I should dig the problem more deeply.
I will resend the patch for fix the comments. Thanks.

On Sun, Aug 21, 2011 at 6:36 PM, Neil Horman <nhorman@xxxxxxxxxxxxx> wrote:
>
> Concur. ÂThe comment should be changed
> Neil
>
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> >On 08/21, Oleg Nesterov wrote:
> >>
> >> On 08/21, bookjovi@xxxxxxxxx wrote:
> >> >
> >> > For non-pipe case, limit 0 also means drop the coredump, so just put
> >> > the zero limit check at do_coredump function begining.
> >>
> >> Neil, what do you think? Should we change the code or the comment?
> >
> >Personally I think we should fix the comment. I think RLIMIT_CORE
> >doesn't apply in this case, limit == 1 check is very special. And
> >this is what linux always did, except between 725eae32 and 898b374a.
> >
> >
> >Oleg.
> >
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/