Re: [PATCHv4 1/4] usb: Provide usb_speed_string() function

From: Michal Nazarewicz
Date: Mon Aug 22 2011 - 17:16:15 EST


+obj-$(CONFIG_USB) += common.o
+obj-$(CONFIG_USB_GADGET) += common.o

Will this cause problems? For example, what if CONFIG_USB is Y and
CONFIG_USB_GADGET is M?

Also, it seems a little silly to have an entire kernel module devoted
to a single, little function.

On Mon, 22 Aug 2011 23:06:43 +0200, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
You could do:

obj-$(CONFIG_USB_SUPPORT) += common.o

which would build that subroutine into the main kernel whenever either
side of the USB stack is enabled.

OK. I'll wait for any more possible comments and post changed version
by the end of the week.

--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michal "mina86" Nazarewicz (o o)
ooo +-----<email/xmpp: mnazarewicz@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/