Re: [PATCH 07/15] x86: add xadd helper macro

[H. Peter Anvin]

On 08/22/2011 04:15 PM, Jeremy Fitzhardinge wrote:
> From: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> 
> Add a common xadd implementation.
> 
> This has the side effect of generating a bad instruction if you try to
> use it on a 64-bit value on a 32-bit system - but don't do that.
> 

It would be better to barf at that point, so we get the error with a C
line... also, there needs to be a default clause with
__compiletime_error() in it.

There are a few additional xadd users which should be converted unless
I'm mistaken:

rwsem_atomic_update() in asm/rwsem.h.

atomic_add_return() in asm/atomic.h.

atomic64_add_return() in asm/atomic64_64.h.

atom_asr() in asm/uv/uv_bau.h (*VOMIT* - the UV people have created a
whole different type in private code...)

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/