Re: [Doc] class_find_device: fix reference to argument

From: Greg KH
Date: Mon Aug 22 2011 - 20:56:03 EST


On Sun, Aug 21, 2011 at 02:53:55PM -0700, Randy Dunlap wrote:
> On Sun, 21 Aug 2011 14:46:04 +0000 (UTC) Wanlong Gao wrote:
>
> > Rolf Eike Beer <eike <at> sf-mail.de> writes:
> >
> > >
> > > Signed-off-by: Rolf Eike Beer <eike-kernel <at> sf-tec.de>
> > > ---
> > > drivers/base/class.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> >
> > > - * @fn is allowed to do anything including calling back into class
> > > + * @match is allowed to do anything including calling back into class
> > > * code. There's no locking restriction.
> > > */
> > > struct device *class_find_device(struct class *class, struct device *start,
> >
> > NACK, it means the function class_find_device but not the @match.
>
> Are you sure? Looks to me like a comment that was copied from
> class_for_each_device() but shouldn't have been copied.
>
> Anyway, I'll cc: Greg to see if he knows.

I think the above patch is probably correct, as it can reenter if
needed.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/