Re: [PATCH 3/4] drivers/usb/host/ohci-omap3.c: test thejust-initialized value

From: Felipe Balbi
Date: Tue Aug 23 2011 - 06:01:39 EST


On Mon, Aug 22, 2011 at 04:00:35PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@xxxxxxx>
>
> Test the just-initialized value rather than some other one.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> identifier x,y,f!={PTR_ERR,ERR_PTR,ERR_CAST};
> statement S;
> @@
>
> x = f(...);
> (
> if (\(x == NULL\|IS_ERR(x)\)) S
> |
> *if (\(y == NULL\|IS_ERR(y)\))
> { ... when != x
> return ...; }
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@xxxxxxx>

applied, thanks

--
balbi

Attachment: signature.asc
Description: Digital signature