Re: [PATCHv4 3/4] usb: gadget: rename usb_gadget_driver::speed to max_speed

From: Dave Young
Date: Tue Aug 23 2011 - 22:27:09 EST


On Tue, Aug 23, 2011 at 12:04 AM, Michal Nazarewicz
<mnazarewicz@xxxxxxxxxx> wrote:
> From: Michal Nazarewicz <mina86@xxxxxxxxxx>
>
> This commit renames the âspeedâÂfield of the usb_gadget_driver
> structure to âmax_speedâ. ÂThis is so that to make it more
> apparent that the field represents the maximum speed gadget
> driver can support.
>
> This also make the field look more like fields with the same
> name in usb_gadget and usb_composite_driver structures. ÂAll
> of those represent the *maximal* speed given entity supports.
>
> After this commit, there are the following fields in various
> structures:
> * usb_gadget::speed - the current connection speed,
> * usb_gadget::max_speed - maximal speed UDC supports,
> * usb_gadget_driver::max_speed - maximal speed gadget driver
> Âsupports, and
> * usb_composite_driver::max_speed - maximal speed composite
> Âgadget supports.
>
> Signed-off-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
> ---
> Âdrivers/usb/gadget/amd5536udc.c  |  Â2 +-
> Âdrivers/usb/gadget/ci13xxx_udc.c Â| Â Â2 +-
> Âdrivers/usb/gadget/composite.c  Â|  Â8 ++++----
> Âdrivers/usb/gadget/dbgp.c     |  Â2 +-
> Âdrivers/usb/gadget/dummy_hcd.c  Â|  13 ++++++-------
> Âdrivers/usb/gadget/file_storage.c | Â Â4 ++--
> Âdrivers/usb/gadget/gmidi.c    Â|  Â2 +-
> Âdrivers/usb/gadget/goku_udc.c   |  Â2 +-
> Âdrivers/usb/gadget/inode.c    Â|  Â6 +++---
> Âdrivers/usb/gadget/m66592-udc.c  |  Â2 +-
> Âdrivers/usb/gadget/net2272.c   Â|  Â2 +-
> Âdrivers/usb/gadget/net2280.c   Â|  Â2 +-
> Âdrivers/usb/gadget/pch_udc.c   Â|  Â2 +-
> Âdrivers/usb/gadget/printer.c   Â|  Â2 +-
> Âdrivers/usb/gadget/r8a66597-udc.c | Â Â2 +-
> Âinclude/linux/usb/gadget.h    Â|  Â4 ++--
> Â16 files changed, 28 insertions(+), 29 deletions(-)
>

Still missing drivers/usb/musb/musb_gadget for the speed check


--
Regards
Yang RuiRui
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/