Re: [patch 1/2]block: change force plug flush call order

[Jens Axboe]

On 2011-08-24 10:55, Shaohua Li wrote:
> Do blk_flush_plug_list() first and then add new request at the tail. New
> request can't be merged to existing requests, but later new requests might
> be merged with this new one. If blk_flush_plug_list() is done later, the
> merge doesn't happen.
> Believe it or not, this fixes a 10% regression running sysbench workload.

Heh, funky. But conceptually it makes sense to flush first, since we
already know that this request isn't mergeable already. Applied.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/