Re: [PATCHv3 2/4] usb: gadget: replace "is_dualspeed" with"max_speed"

[Michal Nazarewicz]

On Wed, 24 Aug 2011 17:15:29 +0200, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>  
wrote:

> On Wed, 24 Aug 2011, Michal Nazarewicz wrote:
>
> > I've found where my reasoning was faulty.  The usb_gadget_driver's
> > max_speed is set before all the functions get added so composite.c has
> > no way to figure those things in advance.  That's why we need to relay
> > on usb_composite_driver's max_speed be set to a proper value.
>
> This is what Felipe was complaining about earlier.  We shouldn't set
> max_speed or allow the UDC to connect to the host until all the
> functions have been added.

We're not doing the latter.  The functions are added in bind callback so
(hopefully) UDC will first run the bind callback and then try connecting
to host.

And the former would be fixed if we allowed gadget driver to set max_speed
in bind callback rather then prior to calling usb_gadget_probe_driver().

--
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/