Re: [PATCH 06/18] x86/ticketlock: make __ticket_spin_trylock common

From: Jeremy Fitzhardinge
Date: Wed Aug 24 2011 - 17:48:59 EST


On 08/24/2011 02:43 PM, Andi Kleen wrote:
> On Wed, Aug 24, 2011 at 02:38:12PM -0700, Linus Torvalds wrote:
>> On Wed, Aug 24, 2011 at 1:00 PM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
>>> Can't we just get rid of the small ticket size code path?
>>>
>>> I couldn't benchmark any difference between the two last time
>>> I tried.
>> The small locks aren't any faster. They are just smaller.
> Are you sure?
>
> AFAIK it's always
>
> typedef struct arch_spinlock {
> unsigned int slock;
> } arch_spinlock_t;

Hm, I changed that in this series; arch_spinlock can be 16 bits in the
<256 case. I wonder if it matters...

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/