Re: [PATCH 00/18] x86: Ticket lock + cmpxchg cleanup

[Jeremy Fitzhardinge]

On 08/24/2011 11:24 AM, Linus Torvalds wrote:
> On Wed, Aug 24, 2011 at 11:03 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>> The patches look good to me, and 50 lines less is always nice too!
>>
>> Acked-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> So I mostly agree, except for the abortion that is the
> __ticket_spin_unlock changes. Please just kill that part.

Could we just kill SMP support for OOSTORE machines now?  That would be
the cleanest possible fix...

> So I'd much have preferred that the xadd helper go in first (07/18),
> then the patch to make __ticket_spin_lock the same for 32/64 would go
> in next (04/18) using that helper, and then they'd just have been
> identical automatically.
>
> Instead, there are a few patches that actually make the code uglier
> temporarily, only to then be undone later. That seems bogus, when it
> looks so simple to fix it.

Yep, OK.  The current series is a history of incremental development; I
can easily clean it up into something that appeared perfectly formed.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/