RE: [PATCH] Input: adp5588-keys - remove incorrect modalias

From: Hennerich, Michael
Date: Thu Aug 25 2011 - 06:44:16 EST


Axel Lin wrote on 2011-08-25:
> From 2b642fd34e59291764f5149f083d84760d8b41b2 Mon Sep 17 00:00:00 2001
> From: Axel Lin <axel.lin@xxxxxxxxx>
> Date: Thu, 25 Aug 2011 18:26:56 +0800
> Subject: [PATCH] Input: adp5588-keys - remove incorrect modalias
>
> For i2c drivers, we should use "i2c:" prefix for modalias.
> MODULE_DEVICE_TABLE will setup the modulalias for us,
> thus adding a MODULE_ALIAS here seems redundant.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

> ---
> drivers/input/keyboard/adp5588-keys.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
> diff --git a/drivers/input/keyboard/adp5588-keys.c
> b/drivers/input/keyboard/adp5588-keys.c index 7b404e54..e34eeb8 100644
> --- a/drivers/input/keyboard/adp5588-keys.c +++
> b/drivers/input/keyboard/adp5588-keys.c @@ -668,4 +668,3 @@
> module_exit(adp5588_exit);
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Michael Hennerich <hennerich@xxxxxxxxxxxxxxxxxxxx>");
> MODULE_DESCRIPTION("ADP5588/87 Keypad driver");
> -MODULE_ALIAS("platform:adp5588-keys");

Greetings,
Michael

--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif


¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶Ÿÿà -»+ƒùdš_