Re: [PATCH] staging/olpc_dcon: Remove obsolete cleanup forclientdata

[Andres Salomon]

Thanks!

Acked-by: Andres Salomon <dilinger@xxxxxxxxxx>

On Thu, 25 Aug 2011 12:53:30 +0200
Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote:

> A few new i2c-drivers came into the kernel which clear the
> clientdata-pointer on exit or error. This is obsolete meanwhile, the
> core will do it.
> 
> Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
> Cc: Andres Salomon <dilinger@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Marek Belisko <marek.belisko@xxxxxxxxxxxxxxx>
> Cc: Jean Delvare <khali@xxxxxxxxxxxx>
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
> b/drivers/staging/olpc_dcon/olpc_dcon.c index 750fe50..a235330 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -712,7 +712,6 @@ static int dcon_probe(struct i2c_client *client,
> const struct i2c_device_id *id) eirq:
>  	free_irq(DCON_IRQ, dcon);
>   einit:
> -	i2c_set_clientdata(client, NULL);
>  	kfree(dcon);
>  	return rc;
>  }
> @@ -721,8 +720,6 @@ static int dcon_remove(struct i2c_client *client)
>  {
>  	struct dcon_priv *dcon = i2c_get_clientdata(client);
>  
> -	i2c_set_clientdata(client, NULL);
> -
>  	fb_unregister_client(&dcon->fbevent_nb);
>  	unregister_reboot_notifier(&dcon->reboot_nb);
>  	atomic_notifier_chain_unregister(&panic_notifier_list,
> &dcon_panic_nb);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/