Re: [PATCH v3 11/13] of: add property iteration helpers

From: Jamie Iles
Date: Fri Aug 26 2011 - 05:26:39 EST


On Thu, Aug 25, 2011 at 05:43:42PM -0600, Stephen Warren wrote:
> This patch adds macros for_each_u32_property_value and
> for_each_string_property_value, which iterate over an array of values
> within a device-tree property. Usage is for example:
>
> struct of_iter_string_prop iter;
> for_each_string_property_value(iter, np, "pins")
> printk("Got value %s\n", iter.value);
>
> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>

Nicely implemented! For the !CONFIG_OF case, I *think* that
of_iter_u32_prop and of_iter_string_prop can be empty struct's, but I
wouldn't want to bet money on that!

Reviewed-by: Jamie Iles <jamie@xxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/