Re: RFD: x32 ABI system call numbers

From: Linus Torvalds
Date: Fri Aug 26 2011 - 20:44:35 EST


On Fri, Aug 26, 2011 at 5:36 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> There is *ZERO* reason to not use it. Use the standard 64-bit
> structure layout. Why the hell would it be a new system call?

Oh, I see why you do that. It's because our 64-bit 'struct stat' uses
"unsigned long" etc.

Just fix that. Make it use __u64 instead of "unsigned long", and
everything should "just work". The 64-bit kernel will not change any
ABI, and when you compile your new ia32 model, it will do the right
thing too.

The fact that we still use "unsigned long" in the x86 <asm/stat.h> is
certainly a bit embarrassing, but I guess that all predates us being
more aware of 32/64-bit issues. It really should be fixed regardless
of any ia32 interface issues.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/