Re: [PATCH] serial: sh-sci: don't filter on DMA device, use only channel ID

[Paul Mundt]

On Fri, Jun 24, 2011 at 05:17:51PM +0530, Koul, Vinod wrote:
> On Fri, 2011-06-24 at 13:56 +0200, Guennadi Liakhovetski wrote:
> > On some sh-mobile systems there are more than one DMA controllers, that
> > can be used for serial ports. Specifying a DMA device in sh-sci platform
> > data unnecessarily restricts the driver to only use one DMA controller.
> > 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> > ---
> >  drivers/tty/serial/sh-sci.c |   25 ++++++++-----------------
> >  include/linux/serial_sci.h  |    2 --
> >  2 files changed, 8 insertions(+), 19 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> > index ebd8629..8711f4e 100644
> > --- a/drivers/tty/serial/sh-sci.c
> > +++ b/drivers/tty/serial/sh-sci.c
> > @@ -1295,12 +1295,8 @@ static bool filter(struct dma_chan *chan, void *slave)
> >  	dev_dbg(chan->device->dev, "%s: slave ID %d\n", __func__,
> >  		param->slave_id);
> >  
> > -	if (param->dma_dev == chan->device->dev) {
> > -		chan->private = param;
> > -		return true;
> > -	} else {
> > -		return false;
> > -	}
> > +	chan->private = param;
> > +	return true;
> You should not assign chan->private. 
> Please move this  to dma_slave_control API

I haven't seen any reply to this comment and this patch seems to still be
outstanding, is there an updated version of this patch that I've missed?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/