Re: [v2 2/4] platform: (TS-5500) add GPIO support

[Mark Brown]

On Fri, Aug 26, 2011 at 07:40:25PM -0400, Vivien Didelot wrote:

>  arch/x86/platform/ts5500/ts5500_gpio.c |  421 ++++++++++++++++++++++++++++++++
>  arch/x86/platform/ts5500/ts5500_gpio.h |   60 +++++

New GPIO drivers should really go under drivers/gpiolib and be called
gpio-foo.c.

> +static int ts5500_gpio_request(struct gpio_chip *chip, unsigned offset)
> +{
> +	struct ts5500_drvdata *drvdata;
> +
> +	drvdata = container_of(chip, struct ts5500_drvdata, gpio_chip);
> +
> +	mutex_lock(&drvdata->gpio_lock);
> +	if (requested_gpios[offset]) {
> +		mutex_unlock(&drvdata->gpio_lock);
> +		return -EBUSY;
> +	}
> +	requested_gpios[offset] = 1;
> +	mutex_unlock(&drvdata->gpio_lock);

gpiolib should already be making sure there's only one user at once, no
need to bother open coding it in the driver.

> +	bitno = line_to_bit_map[offset];
> +
> +	mutex_lock(&drvdata->gpio_lock);
> +	byte = inb(ioaddr);
> +	mutex_unlock(&drvdata->gpio_lock);

Do you really need the lock to do a read?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/